Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how DeviceName links configuration and data IO operators #288

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Sep 5, 2024

- Added remarks to all device configuraiton and data IO operators
indicating that they can be linked through the use of a shared
DeviceName
Copy link
Member

@cjsha cjsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one felt like a lot of work, good job. I approved, but please go through and consider comments before merging.

OpenEphys.Onix1/Bno055Data.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/ConfigureBno055.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/ConfigureLoadTester.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/ConfigureBreakoutAnalogIO.cs Show resolved Hide resolved
OpenEphys.Onix1/ConfigureHeadstage64OpticalStimulator.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/ConfigureHarpSyncInput.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/ConfigureTS4231V1.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/DeviceFactory.cs Outdated Show resolved Hide resolved
- Removed self-referential crefs to DeviceName in XML docs
- Other typo fixes
@jonnew jonnew merged commit 1c74d68 into main Sep 6, 2024
7 checks passed
@jonnew jonnew deleted the issue-207 branch September 6, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description connecting <xyz>Data operators and configure<xyzHeadstage> operators
2 participants