Fix loading channel configuration files #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove manual throws in code - Add an error handler to the JsonConvert.DeserializeObject call
- Instead of only copying over the device channel indices, now all aspects of a probe are copied and saved - Bump OpenEphys.ProbeInterface.NET version to 0.1.1 to take advantage of patch fix - Added internal methods to calculate contours if no probe contours are given - Correctly removes scale points
- Instead of showing first JSON parse error, print all of them to stderr - Realized that static functions in the NeuropixelsV1Helper.cs should really accept a path instead of a StreamReader as their first arguement because StreamReader is to general because cal data is always provided in a file and this function call expects to start from the beginning of the stream. This will require a change in the public API. I will open a new issue about this.
jonnew
approved these changes
Sep 3, 2024
|
Issue documented in my last commit is opened in #283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, channel configuration files that are malformed or are missing required fields no longer throw an exception that forcibly closes the dialog. Exceptions are routed appropriately to notify the user instead.
Fixes #252
Additionally, files that contain changes other than the device channel indices are now respected. Previously, only the device channel indices were being saved, which meant that channels could be enabled and disabled by reading in a configuration file, but if the probe contour or contact shapes were modified those changes were not reflected in the GUI.
Fixes #271
Finally, an emergent property of fixing #271 led to a bug in drawing the scale bar after loading files without a probe contour. This has been addressed as well in this PR, but no issue was created for it.