Rename hub base class to multi-device factory for clarity #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
added
documentation
glopesdev
force-pushed
the
naming-refactor
branch
from
db49239
to
ba63945
Compare
bparks13
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HubDeviceFactoryhas evolved to represent not only proper ONI hubs, but virtually any composite configuration of a multi-device aggregate. This includes hardware headstages but also potentially fully virtual devices.To reflect this flexibility in intended use we are renaming the base class to
MultiDeviceFactory. Other associated classes and docs have also been renamed for naming consistency.