-
Couldn't load subscription status.
- Fork 20
04-rwslotmachine4: Add Dockerfile #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
04-rwslotmachine4: Add Dockerfile #55
Conversation
06648b5 to
09e236d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are other Dockerfile files using two stages?
Should there be a Makefile to build the application (and run make inside the Dockerfile), and a Makefile to automate the process of building and running Docker? As in this PR.
...ions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/Dockerfile
Outdated
Show resolved
Hide resolved
...ions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/Dockerfile
Outdated
Show resolved
Hide resolved
...ions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/Dockerfile
Outdated
Show resolved
Hide resolved
...ions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/Dockerfile
Outdated
Show resolved
Hide resolved
...ions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/Dockerfile
Outdated
Show resolved
Hide resolved
...ions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/Dockerfile
Outdated
Show resolved
Hide resolved
...tions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/README.md
Outdated
Show resolved
Hide resolved
...tions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/README.md
Outdated
Show resolved
Hide resolved
...tions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/README.md
Show resolved
Hide resolved
...tions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/README.md
Outdated
Show resolved
Hide resolved
7e636b6 to
75743c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extend your commit message with a commit description. Mention the rationale / motivation for adding a Dockerfile.
I would suggest, if possible, you renamed the Makefile to Makefile.sol. And add a new Makefile that is going to be used for deploying the Docker container, similar to the one below:
PORT ?= 31900
IMG_NAME ?= ez
CONT_NAME ?= $(IMG_NAME)-cnt
build:
docker build -t $(IMG_NAME) -f Dockerfile ..
run: build
docker run -d --rm -p $(PORT):31337 --name $(CONT_NAME) -t $(IMG_NAME)
stop:
-docker stop $(CONT_NAME)
clean: stop
docker rm $(CONT_NAME)
.PHONY: build run stop clean
...ations-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/Makefile
Outdated
Show resolved
Hide resolved
...ations-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/Makefile
Outdated
Show resolved
Hide resolved
...tions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/README.md
Outdated
Show resolved
Hide resolved
75743c4 to
97f2427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ending newline in all files.
...tions-and-defensive-strategies/defense-mechanisms/activities/04-rwslotmachine4/sol/README.md
Outdated
Show resolved
Hide resolved
97f2427 to
450fc72
Compare
Add Dockerfile and Makefile to containerize 04-rwslotmachine4 app Signed-off-by: Amalia Ionescu <ionescu.amalia98@gmail.com>
450fc72 to
b9188ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
5a0053f to
96f02af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Tab-based indenting for the implementation of read_int().
96f02af to
979de0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu mailto:razvand@unikraft.io
Add implementation of read_int() for integer input parsing Signed-off-by: Amalia Ionescu <ionescu.amalia98@gmail.com>
979de0f to
7843fd5
Compare
…rwslotmachine4
Prerequisite Checklist
Description of changes