Day0 separate create and delete tests #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| day2Label = "infra-tests-day2" | ||
| day1Label = "infra-tests-day1" | ||
| day0Label = "infra-tests-day0" | ||
| day0CreateLabel = "infra-tests-day0-create" |
There was a problem hiding this comment.
Maybe change this to day0CreateLabel = "infra-tests-custom-day0-create"
So it does not get executed when tests with the label infra-tests-day0 are called.
Same for the delete one.
jkossak
requested review from
Andrea-Campanella,
cjnolan,
damiankopyto,
daniele-moro,
ikyrycho,
ktaube26,
niket-intc,
osinstom,
Paiadhithi,
PalashGoelIntel,
pierventre,
rranjan3,
soniabha-intc and
sunil-parida
as code owners
jkossak
requested review from
tmatenko,
vthiruveedula,
zdw and
Ram-srini
as code owners
pierventre
approved these changes
May 29, 2025
patricia-cahill
approved these changes
May 29, 2025
raphaelvrosa
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two day0 infra test cases that split existing day0 behavior into:
The new test cases use new labels.
Tested in open-edge-platform/infra-charts#45
Ticket: ITEP-27768
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: