Skip to content

Adds protoc-gen-connect-openapi as plugin for apiv2 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 28, 2025
Merged

Conversation

raphaelvrosa
Copy link
Contributor

@raphaelvrosa raphaelvrosa commented May 28, 2025

Description

Replaces kollalabs with protoc-gen-connect-openapi plugin for apiv2 auto-generation of OpenAPI spec in apiv2.
The new plugin is more flexible and generates proper/extensive validation rules, besides it generates proper enum messages.
In addition, this PR adds:

  • Proper error parsing and return in REST API, filtering the error details in the returned message;
  • Adds missing fields from previous api (e.g., instance_status_detail)
  • Defines page_size and offset as uint32 (integer in openapi spec)
  • Sets maximum values for start/end seconds in single schedule

Fixes # (issue)

Any Newly Introduced Dependencies

Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

@sys-orch sys-orch added the root label May 28, 2025
Copy link
Contributor

@pierventre pierventre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please inform app-orch team of this change

@raphaelvrosa raphaelvrosa merged commit d941a73 into main May 28, 2025
20 checks passed
@raphaelvrosa raphaelvrosa deleted the itep-67388-fix branch May 28, 2025 13:04
@pierventre pierventre mentioned this pull request May 28, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants