Skip to content

Conversation

@pplaskie
Copy link
Contributor

@pplaskie pplaskie commented Oct 3, 2025

📝 Description

PhotoPlaceholder was already used in geti to handle things that do not have email and it is also used in other geti applications - email is used for color generation.

I've changed email to indicator attribute to have more sense in other use cases than handling users.

Note: after merging this pr component in other applications have to be updated

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Run automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and meaningful
  • ✍️ PR description clearly explains the changes and their reason
  • 📝 I have linked the PR to the corresponding GitHub Issues, if any
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

Copilot AI review requested due to automatic review settings October 3, 2025 09:24
@pplaskie pplaskie added the UI label Oct 3, 2025
@pplaskie pplaskie review requested due to automatic review settings October 3, 2025 09:24
@dwesolow dwesolow added this pull request to the merge queue Oct 3, 2025
Merged via the queue into main with commit 9d647e4 Oct 3, 2025
45 of 47 checks passed
@dwesolow dwesolow deleted the pplaskie/adjust_photo_placeholder_attribute branch October 3, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants