Skip to content

Conversation

pplaskie
Copy link
Contributor

📝 Description

This pr contains changes required for Geti Prompt - component is exposed in @geti/ui and proper changes were made to be able to use this component in medium size.

image

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Run automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and meaningful
  • ✍️ PR description clearly explains the changes and their reason
  • 📝 I have linked the PR to the corresponding GitHub Issues, if any
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

@Copilot Copilot AI review requested due to automatic review settings September 23, 2025 07:27
@pplaskie pplaskie added the UI label Sep 23, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the ColorPickerDialog component to be exposed from the @geti/ui package instead of being imported from internal file paths. It also adds medium size support to the color picker dialog.

  • Moved ColorPickerDialog component to @geti/ui package with proper exports
  • Added medium ('M') size support to the color picker dialog
  • Updated all import references to use the new package export

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
web_ui/src/shared/components/label-tree-view/label-tree-view-item/label-edition-mode/label-edition-mode.component.tsx Updated import to use ColorPickerDialog from @geti/ui
web_ui/src/pages/landing-page/landing-page-workspace/components/dataset-import-to-new-project/dataset-import-to-new-project-labels.component.tsx Updated import to use ColorPickerDialog from @geti/ui
web_ui/src/pages/create-project/components/project-labels-management/utils.ts Removed validateColor utility function
web_ui/src/pages/create-project/components/project-labels-management/task-labels-management/new-label-tree-item/label-tree-label.component.tsx Updated import to use ColorPickerDialog from @geti/ui
web_ui/packages/ui/src/color-picker-dialog/utils.ts Added validateColor utility function to the UI package
web_ui/packages/ui/src/color-picker-dialog/color-picker-dialog.component.tsx Added medium size support and improved type definitions
web_ui/packages/ui/src/color-picker-dialog/change-color-button.component.tsx Added medium size support with proper sizing parameters
web_ui/packages/ui/index.ts Exported ColorPickerDialog component from the UI package

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

dwesolow
dwesolow previously approved these changes Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants