Skip to content

Chore: Reduce verbosity of buildall #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2025
Merged

Chore: Reduce verbosity of buildall #247

merged 3 commits into from
May 1, 2025

Conversation

zdw
Copy link
Contributor

@zdw zdw commented Apr 30, 2025

Description

Reduce verbosity of buildall process, while retaining debuggability.

List external requirements, from individual repos that are built.

How Has This Been Tested?

Run manually, which is enough for buildall.

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

@zdw zdw requested a review from puneet-intel April 30, 2025 03:55
Andrea-Campanella
Andrea-Campanella approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@Andrea-Campanella Andrea-Campanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's would be worth to attach to the PR an example of a total output for people to quickly review at a glance.

palade
palade reviewed Apr 30, 2025
View reviewed changes
Copy link
Contributor

@palade palade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one comment

@zdw
Copy link
Contributor Author

zdw commented May 1, 2025

I think it's would be worth to attach to the PR an example of a total output for people to quickly review at a glance.

It's super boring, but looks like this - enough information to know what is happening so the user can debug a problem, by going into the logfiles in the scratch/ dir:

$ make buildall
## All repos have been checked out ##
### Generating artifact list in 'repos/orch-utils' ###
### Generating artifact list in 'repos/o11y-alerting-monitor' ###
### Generating artifact list in 'repos/o11y-charts' ###
### Generating artifact list in 'repos/o11y-sre-exporter' ###
### Generating artifact list in 'repos/o11y-tenant-controller' ###
### Generating artifact list in 'repos/app-orch-catalog' ###
### Generating artifact list in 'repos/app-orch-deployment' ###
### Generating artifact list in 'repos/app-orch-tenant-controller' ###
### Generating artifact list in 'repos/cluster-api-provider-intel' ###
### Generating artifact list in 'repos/cluster-connect-gateway' ###
### Generating artifact list in 'repos/cluster-manager' ###
### Generating artifact list in 'repos/infra-charts' ###
### Generating artifact list in 'repos/infra-core' ###
### Generating artifact list in 'repos/infra-external' ###
### Generating artifact list in 'repos/infra-managers' ###
### Generating artifact list in 'repos/infra-onboarding' ###
### Generating artifact list in 'repos/orch-metadata-broker' ###
### Generating artifact list in 'repos/orch-ui' ###
## All artifact lists have been created ##
## Generating releaseManifest of required helm charts ##
Created release manifest: buildall/scratch/manifest_charts.yaml
### Running 'make helm-build' in 'repos/o11y-sre-exporter', tag: 'v0.9.0' ###
### Running 'make helm-build' in 'repos/o11y-charts', tag: 'charts/edgenode-dashboards-0.3.5' ###
### Running 'make helm-build' in 'repos/o11y-alerting-monitor', tag: 'v1.7.0' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/adm-secret/v1.0.2' ###
### All helm chart builds complete in 'repos/o11y-sre-exporter', took 3s ###
### Running 'make helm-build' in 'repos/o11y-tenant-controller', tag: 'v0.6.0' ###
### All helm chart builds complete in 'repos/o11y-tenant-controller', took 2s ###
### Running 'make helm-build' in 'repos/app-orch-catalog', tag: 'v0.11.33' ###
### All helm chart builds complete in 'repos/app-orch-catalog', took 3s ###
#### Copying Makefile from main branch as helm-build target doesn't exist ####
### Running 'make helm-build' in 'repos/app-orch-deployment', tag: 'app-resource-manager/v2.3.27' ###
### All helm chart builds complete in 'repos/o11y-alerting-monitor', took 10s ###
### Running 'make helm-build' in 'repos/app-orch-tenant-controller', tag: 'v0.2.13' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/auth-service/v1.0.2' ###
### All helm chart builds complete in 'repos/app-orch-tenant-controller', took 4s ###
### Running 'make helm-build' in 'repos/cluster-api-provider-intel', tag: 'v1.0.5' ###
### All helm chart builds complete in 'repos/cluster-api-provider-intel', took 3s ###
### Running 'make helm-build' in 'repos/cluster-connect-gateway', tag: 'v1.0.6' ###
#### Copying Makefile from main branch as helm-build target doesn't exist ####
### Running 'make helm-build' in 'repos/app-orch-deployment', tag: 'app-deployment-manager/v2.3.44' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/aws-lb-tgb/v1.0.1' ###
### All helm chart builds complete in 'repos/cluster-connect-gateway', took 5s ###
### Running 'make helm-build' in 'repos/cluster-manager', tag: 'v2.0.7' ###
### All helm chart builds complete in 'repos/cluster-manager', took 4s ###
#### Copying Makefile from main branch as helm-build target doesn't exist ####
### Running 'make helm-build' in 'repos/app-orch-deployment', tag: 'app-interconnect/v0.1.18' ###
### Running 'make helm-build' in 'repos/infra-charts', tag: 'infra-core-2.8.2' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/aws-sm-get-rs-token/v0.3.1' ###
### Running 'make helm-build' in 'repos/app-orch-deployment', tag: 'app-service-proxy/v1.3.23' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/aws-sm-proxy/v0.4.2' ###
### All helm chart builds complete in 'repos/app-orch-deployment', took 34s ###
### No helm charts built in repos/infra-core ###
### No helm charts built in repos/infra-external ###
### No helm charts built in repos/infra-managers ###
### No helm charts built in repos/infra-onboarding ###
### Running 'make helm-build' in 'repos/orch-metadata-broker', tag: 'v0.4.11' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/capi-operator-pre/v1.0.1' ###
### Running 'make helm-build' in 'repos/infra-charts', tag: 'infra-external-2.1.3' ###
### All helm chart builds complete in 'repos/orch-metadata-broker', took 1s ###
### Running 'make helm-build' in 'repos/o11y-charts', tag: 'charts/edgenode-observability-0.10.0' ###
### Running 'make helm-build' in 'repos/orch-ui', tag: 'apps/admin/2.0.11' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/cert-synchronizer/v1.0.3' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/certificate-file-server/v1.0.1' ###
### Running 'make helm-build' in 'repos/infra-charts', tag: 'infra-managers-2.12.4' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/copy-secret/v1.0.1' ###
### Running 'make helm-build' in 'repos/orch-ui', tag: 'apps/app-orch/2.0.16' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/fleet-rs-secret/v2.0.4' ###
### Running 'make helm-build' in 'repos/infra-charts', tag: 'infra-onboarding-1.29.8' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/istio-policy/v2.0.5' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/job-wait/v1.1.2' ###
### Running 'make helm-build' in 'repos/orch-ui', tag: 'apps/cluster-orch/2.0.15' ###
### Running 'make helm-build' in 'repos/o11y-charts', tag: 'charts/orchestrator-dashboards-0.3.1' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/k8s-metrics-server/v0.1.1' ###
### All helm chart builds complete in 'repos/infra-charts', took 69s ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/keycloak-tenant-controller/v1.0.11' ###
### Running 'make helm-build' in 'repos/orch-ui', tag: 'apps/infra/1.0.10' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/kyverno-extra-policies/v3.0.3' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/kyverno-istio-policy/v1.0.1' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/kyverno-traefik-policy/v1.1.1' ###
### Running 'make helm-build' in 'repos/orch-ui', tag: 'apps/root/2.0.10' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/metallb-config/v1.0.1' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/namespace-label/v0.2.4' ###
### Running 'make helm-build' in 'repos/o11y-charts', tag: 'charts/orchestrator-observability-0.5.1' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/nexus-api-gw/v0.1.12' ###
### All helm chart builds complete in 'repos/orch-ui', took 94s ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/nginx-ingress-pxe-boots/v1.1.1' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/oci-secret/v2.0.3' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/platform-autocert/v1.0.2' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/postgresql-secrets/v1.0.1' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/rs-image-pull-secrets/v1.0.1' ###
### All helm chart builds complete in 'repos/o11y-charts', took 170s ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/rs-proxy/v1.1.6' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/secret-wait/v1.2.2' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/secrets-config/v3.0.3' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/self-signed-cert/v4.0.8' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/squid-proxy/v0.2.3' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/tenancy-api-mapping/v0.4.1' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/tenancy-datamodel/v0.2.1' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/tenancy-manager/v0.1.7' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/token-fs/v1.2.2' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/token-refresh/v0.4.3' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/traefik-extra-objects/v4.1.9' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/traefik-pre/v3.0.1' ###
### Running 'make helm-build' in 'repos/orch-utils', tag: 'chart/vertical-pod-autoscaler/v0.0.3' ###
### All helm chart builds complete in 'repos/orch-utils', took 252s ###
## All helm charts have been created ##
## Generating localReleaseImageManifest of docker images from charts ###
INFO: Underspecified image name: bitnami/kubectl
INFO: Underspecified image name: busybox
INFO: Underspecified image name: migrate/migrate
INFO: Duplicate image: 'nginx-unprivileged' has registry 'nginxinc' which doesn't match earlier 'docker.io/nginxinc'
INFO: Underspecified image name: portainer/kubectl-shell
INFO: Duplicate image: 'k8s-sidecar' has registry 'quay.io/kiwigrid' which doesn't match earlier 'kiwigrid'
### Running 'make docker-build-auth-service' in 'repos/orch-utils', tag: 'auth-service/v2.0.0' ###
### Running 'make grafana-proxy-docker-build' in 'repos/o11y-charts', tag: 'apps/grafana-proxy-v0.5.0' ###
### Running 'make docker-build-metrics-exporter' in 'repos/o11y-sre-exporter', tag: 'v0.9.0' ###
### Running 'make docker-build-alerting-monitor' in 'repos/o11y-alerting-monitor', tag: 'v1.7.0' ###
...

@zdw zdw requested a review from palade May 1, 2025 03:56
@zdw zdw added this pull request to the merge queue May 1, 2025
Merged via the queue into main with commit 84f15d0 May 1, 2025
23 checks passed
@zdw zdw deleted the ba_less_verbose branch May 1, 2025 16:00
@ajaythakurintel ajaythakurintel added this to the 3.1 milestone May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palade palade palade approved these changes

@Andrea-Campanella Andrea-Campanella Andrea-Campanella approved these changes

@se-chris-thach se-chris-thach Awaiting requested review from se-chris-thach se-chris-thach is a code owner

@mdbalvin mdbalvin Awaiting requested review from mdbalvin mdbalvin is a code owner

@rad-szulim rad-szulim Awaiting requested review from rad-szulim rad-szulim is a code owner

@charlesmcchan charlesmcchan Awaiting requested review from charlesmcchan charlesmcchan is a code owner

@yi-tseng-intel yi-tseng-intel Awaiting requested review from yi-tseng-intel yi-tseng-intel is a code owner

@ashridatta ashridatta Awaiting requested review from ashridatta ashridatta is a code owner

@teone teone Awaiting requested review from teone teone is a code owner

@callumnobleintel callumnobleintel Awaiting requested review from callumnobleintel callumnobleintel is a code owner

@daniele-moro daniele-moro Awaiting requested review from daniele-moro daniele-moro is a code owner

@SeanCondon SeanCondon Awaiting requested review from SeanCondon SeanCondon is a code owner

@pierventre pierventre Awaiting requested review from pierventre pierventre is a code owner

@cgoea cgoea Awaiting requested review from cgoea cgoea is a code owner

@emmakenny emmakenny Awaiting requested review from emmakenny

@PalashGoelIntel PalashGoelIntel Awaiting requested review from PalashGoelIntel

@pperycz pperycz Awaiting requested review from pperycz pperycz is a code owner

@ltalarcz ltalarcz Awaiting requested review from ltalarcz ltalarcz is a code owner

@jakubsikorski jakubsikorski Awaiting requested review from jakubsikorski jakubsikorski is a code owner

@sys-orch-approve sys-orch-approve Awaiting requested review from sys-orch-approve sys-orch-approve is a code owner

@ahalimx86 ahalimx86 Awaiting requested review from ahalimx86 ahalimx86 is a code owner

@johnoloughlin johnoloughlin Awaiting requested review from johnoloughlin johnoloughlin is a code owner

@garyloug garyloug Awaiting requested review from garyloug garyloug is a code owner

@puneet-intel puneet-intel Awaiting requested review from puneet-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@zdw @palade @Andrea-Campanella @ajaythakurintel