Fix custom callbacks dirpath to be the same as default root dir#2194
Fix custom callbacks dirpath to be the same as default root dir#2194CarlosNacher wants to merge 5 commits intoopen-edge-platform:mainfrom
Conversation
| # (which was updated in _setup_workspace() method) | ||
| for cached_callback in self._cache.args["callbacks"]: | ||
| if hasattr(cached_callback, "dirpath"): | ||
| callback_dirpath = Path(cached_callback.dirpath) |
There was a problem hiding this comment.
is dirpath always the correct/fixed argument name for custom callbacks? If not, this approach may not work I'm afraid.
There was a problem hiding this comment.
@samet-akcay I am not sure if I have correctly understood your concern correcty.
That chunk of code will work with all callbacks that have a dirpath argument. If not, it won't modify anything.
So, do all callbacks which need to be locally logged name its "dirpath_" argument dirpath? I don't know, but in lightning's callbacks docs there is only a callback (ModelCheckpoint) which has to be logged and has the dirpath argument.
Please, let me know if you think I misunderstood your question because I don't know if we are talking about the same concern.
📝 Description
yamlto be logged in the same local path as the other default callbacks.default_root_dirsince anomalib V1 #2117✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.