Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing <cstdint> include #99

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Add missing <cstdint> include #99

merged 1 commit into from
Jan 11, 2025

Conversation

dksmiffs
Copy link
Contributor

@dksmiffs dksmiffs commented Jan 10, 2025

Without this proposed change, the following steps:

cmake -B ./build -S .
cmake --build ./build

Produce the following error with g++ 13.3 and CMake 3.30.3:

open-dis-cpp/src/dis7/IntercomSignalPdu.h:41:15: error: ‘uint8_t’ was not declared in this scope
   41 |   std::vector<uint8_t> _data;
      |               ^~~~~~~
open-dis-cpp/src/dis7/IntercomSignalPdu.h:5:1: note: ‘uint8_t’ is defined in header ‘<cstdint>; did you forget to ‘#include <cstdint>’?

This pull request fixes #98.

@dksmiffs dksmiffs changed the title Add missing <cstdint> include for #98 fix Add missing <cstdint> include Jan 10, 2025
@leif81 leif81 merged commit 358c3df into open-dis:master Jan 11, 2025
1 check passed
@leif81
Copy link
Member

leif81 commented Jan 11, 2025

Thank-you @dksmiffs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing #include to src/dis7/IntercomSignalPdu.h
2 participants