Fix Compiler Warnings + Minor Corrections + OpenDIS7 build target #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sizeof(int) is consistently 32 bit using GCC and MSVC, but sizeof(long) variables from GCC to MSVC.
sizeof(long) varies between GCC & MSVC compilers, while sizeof(long long) is consistently 64 bits Commit also includes some corrections to ArticulatedParts, AttachedParts, and Attribute classes.
|
Thank-you @rodneyp290! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses compiler warnings discussed in issue #29, and the pull request #30.
The warnings were predominately caused by the use of
charinstead ofunsigned char, andintinsteadunsigned long(int).While making these changes, I compared at the sizes of
char,int,long, andlong long, using two different compilers (GCC, and MSVC) and found thatlongvaried between 32 bits and 64 bits depending on the compiler. Because of this discrepancy I replaced alllongs withlong longs, and checked against the DIS standard to confirm altered attributes required 64 bit integers.These check in turn resulted in some minor corrections of the DIS7
AttachedParts, &ArticulatedPartsClasses; and I think theAttributeclass still needs corrections that I'll raise an issue for.Additionally, it adds a build target entry for OpenDIS7 to the premake5 file, and addresses issues #6, to create a successful compile of the DIS 7 code.