(types) Add typedefs for enrollSecondAuthFactor() and `verifySecond…

…AuthFactor). Update typedef for `verifyPhoneNumber()`
open-dining · Nov 7, 2022 · 180f408 · 180f408
1 parent 1256abd
commit 180f408
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 5 deletions.
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -158,11 +158,46 @@ export interface FirebasePlugin {
         error?: (err: string) => void
     ): void
     verifyPhoneNumber(
-        success: (value: object) => void,
+        success: (value: object | boolean) => void,
+        error: (err: string) => void,
+        phoneNumber: string,
+        opts?: {
+            timeOutDuration: number,
+            fakeVerificationCode: string,
+            requireSmsValidation: boolean
+        },
+    ): void
+    enrollSecondAuthFactor(
+        success: (value: object | boolean) => void,
         error: (err: string) => void,
         phoneNumber: string,
-        timeOutDuration: number,
-        fakeVerificationCode?: string
+        opts?: {
+            displayName: string,
+            credential: {
+                verificationId: string,
+                code: string
+            },
+            timeOutDuration: number,
+            fakeVerificationCode: string,
+            requireSmsValidation: boolean
+        },
+    ): void
+    verifySecondAuthFactor(
+        success: (value: object | boolean) => void,
+        error: (err: string) => void,
+        params: {
+            selectedIndex?: number,
+            credential?: {
+                verificationId: string,
+                code: string
+            },
+        },
+        opts?: {
+            timeOutDuration: number,
+            fakeVerificationCode: string,
+            phoneNumber: string,
+            requireSmsValidation: boolean
+        },
     ): void
     setLanguageCode(
         lang: string,

diff --git a/www/firebase.js b/www/firebase.js
@@ -271,14 +271,14 @@ exports.didCrashOnPreviousExecution = function (success, error) {
 
 
 // Authentication
-exports.verifyPhoneNumber = function (success, error, number, opts) {
+exports.verifyPhoneNumber = function (success, error, phoneNumber, opts) {
     if(typeof opts !== 'object') opts = {};
     exec(function(credential){
         if(typeof credential === 'object'){
             credential.instantVerification = ensureBoolean(credential.instantVerification);
         }
         success(credential);
-    }, error, "FirebasePlugin", "verifyPhoneNumber", [number, opts]);
+    }, error, "FirebasePlugin", "verifyPhoneNumber", [phoneNumber, opts]);
 };
 
 exports.enrollSecondAuthFactor = function (success, error, number, opts) {