Improved Exception Handling on File Upload #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved exception logging and handling.
- Added change log file.
- Check for expected sheetnames when inside of generator method.
- Pyright fixes.
JVickery-TBS
added a commit
that referenced
this pull request
Dec 8, 2025
Improved Exception Handling on File Upload
JVickery-TBS
added a commit
that referenced
this pull request
Dec 8, 2025
Improved Exception Handling on File Upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(misc): exception handling;
@wardi this one is to solve a bunch of back and forth with clients, support, and devs. So just adding logs for the
Exceptioncatch when processing upload files. usedlog.infobecause of our prod logger setups (I know, its bad).As for the past few issues like this, I noticed that the common error is a
RuntimeonStopIterationwhich seems to be that the iterator is finishing before expected? This happened inside of theread_exceliter, and when expecting the looping sheetnames, different Excel docs provided by clients had some seemingly machine generated sheetnames.Did some quick researched and found that depending on Excel extensions and Macros and Services that a user may be using on their computer with Excel, they can have hidden sheets in their docs. And those sheets get saved inside the Excel doc they upload. So for now, just skipping over a common one I found which the sheetname contains the word
cacheLet me know if you think it would be better (or possible) to just check for the resource names that we are expecting??