Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for django 4.2 #107

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

irtazaakram
Copy link
Contributor

Hi,

This PR is related to ongoing effort to upgrade openedx to Django 4.2

edx/upgrades#368

Please can we have a new release after this PR is merged.

Thanks,

Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irtazaakram, Django 4 is never used in these tests. It seems that this command installs django==3.2.11 directly from the xblock-sdk requirements.

@irtazaakram
Copy link
Contributor Author

Hi @Agrendalath,

Thank you for the review. I've made some changes in tox that should install Django 4.2 in test env. Also I've updated package versions in requirements.

Thanks,

@Agrendalath
Copy link
Member

@irtazaakram, I proposed an alternative approach at #108. Would you like to cherry-pick 8d3040b into your PR so we can merge it here?

@irtazaakram
Copy link
Contributor Author

Hi @Agrendalath,

I've updated code as per your approach.

Thanks,

@Agrendalath
Copy link
Member

@irtazaakram, please revert the last commit and cherry-pick 8d3040b to ensure all changes are included.

@irtazaakram
Copy link
Contributor Author

@Agrendalath, I've cherry-picked 8d3040b into this branch. Please review.

Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the CI is passing
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@Agrendalath Agrendalath merged commit c0e2feb into open-craft:master Sep 20, 2023
5 checks passed
@Agrendalath Agrendalath mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants