-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BB-7012] Add github ci workflow and update requirements #100
Conversation
cdfbbff
to
e69cf67
Compare
e69cf67
to
65f6413
Compare
fcb3dd2
to
78a534f
Compare
78a534f
to
ce19a22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkulkark, when I run make requirements && make test
locally, there is no output after Creating test database for alias 'default'...
. When I stop the process, I get the following errors:
======================================================================
ERROR: Verifies that a default poll loads, that it can be voted on, and that
----------------------------------------------------------------------
Traceback (most recent call last):
File "/HIDDEN/xblock-poll/tests/integration/base_test.py", line 39, in setUp
super(PollBaseTest, self).setUp()
File "/HIDDEN/virtualenvs/tempenv-055913331076f/src/xblock-utils/xblockutils/base_test.py", line 144, in setUp
super().setUp()
File "/HIDDEN/virtualenvs/tempenv-055913331076f/src/xblock-utils/xblockutils/base_test.py", line 43, in setUp
super().setUp()
File "/HIDDEN/virtualenvs/tempenv-055913331076f/src/xblock-sdk/workbench/test/selenium_test.py", line 25, in setUp
super().setUp()
File "/HIDDEN/virtualenvs/tempenv-055913331076f/lib/python3.8/site-packages/bok_choy/web_app_test.py", line 121, in setUp
self.browser = browser(tags, self.proxy)
File "/HIDDEN/virtualenvs/tempenv-055913331076f/lib/python3.8/site-packages/bok_choy/browser.py", line 247, in browser
browser_instance = Promise(
File "/HIDDEN/virtualenvs/tempenv-055913331076f/lib/python3.8/site-packages/bok_choy/promise.py", line 106, in fulfill
raise BrokenPromise(self)
bok_choy.promise.BrokenPromise: Promise not satisfied: Browser is instantiated successfully.
-------------------- >> begin captured logging << --------------------
bok_choy.browser: INFO: Using local browser: firefox [Default is firefox]
bok_choy.browser: INFO: Using default firefox profile
bok_choy.browser: INFO: Using local browser: firefox [Default is firefox]
bok_choy.browser: INFO: Using default firefox profile
bok_choy.browser: INFO: Using local browser: firefox [Default is firefox]
bok_choy.browser: INFO: Using default firefox profile
--------------------- >> end captured logging << ---------------------
Am I missing something?
f177476
to
ff934b4
Compare
9346209
to
768faab
Compare
@Agrendalath I couldn't figure out why, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please see this comment.
👍
- I tested this: checked that the CI is passing
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository: n/a
768faab
to
962b97a
Compare
Thanks @Agrendalath. I assume you've tried both |
Also adds github ci workflow and removes circleci config as part of #100
Also adds github ci workflow and removes circleci config as part of #100
Also adds github ci workflow and removes circleci config as part of #100
Also adds github ci workflow and removes circleci config as part of #100
Description
This PR removes the circleci workflow and replaces it with github ci. It also updates the requirements, removing python 2.7 and 3.6 support.
Supporting Information
OpenCraft Internal Jira task: BB-7012
Testing Instructions:
Verify that the new github CI tests are all passing and the xblock still functions normally.