Skip to content

WIP: [BB-2096] Make tests less flaky #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

WIP: [BB-2096] Make tests less flaky #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b99c1a6
[BB-2096] Fix problem-builder tests
Agrendalath Mar 9, 2020
47d1312
[BB-2096] Fix problem-builder tests
Agrendalath Mar 9, 2020
226a30d
[BB-2096] Fix problem-builder tests
Agrendalath Mar 9, 2020
0f9eea7
[BB-2096] Fix waiting order for flaky test
Agrendalath Mar 9, 2020
d2130c1
[BB-2096] Fix flaky test delays
Agrendalath Mar 9, 2020
94d916f
Revert "[BB-2096] Fix flaky test delays"
Agrendalath Mar 9, 2020
f6b0dab
[BB-2096] Fix flaky tests
Agrendalath Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion problem_builder/tests/integration/test_instructor_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,8 @@ def test_pagination_multiple_results(self):

start_button.click()

time.sleep(3) # Allow some time for result block to fully fade in.
self.wait_until_visible(result_block)
time.sleep(1) # Allow some time for result block to fully fade in

for contents in [
'Test section', 'Test subsection', 'Test unit',
Expand Down
1 change: 1 addition & 0 deletions problem_builder/tests/integration/test_questionnaire.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ def test_mrq_feedback_popups(self):
choice_wrapper.find_element_by_css_selector(".choice-selector input").click()
item_feedback_icon = choice_wrapper.find_element_by_css_selector(".choice-result")
if item_feedback_icon.is_displayed():
self.wait_until_clickable(item_feedback_icon)
item_feedback_icon.click() # clicking on item feedback icon
item_feedback_popup = choice_wrapper.find_element_by_css_selector(".choice-tips")

Expand Down
1 change: 1 addition & 0 deletions problem_builder/tests/integration/test_step_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,7 @@ def test_mcq_feedback(self, choice_index, choice_text, expected_feedback, correc
def review_mcq(self, step_builder, choice_index, expected_feedback, correct):
correctness = 'correct' if correct else 'incorrect'
mcq_link = step_builder.find_elements_by_css_selector('.{}-list li a'.format(correctness))[0]
self.wait_until_visible(mcq_link)
mcq_link.click()
mcq = step_builder.find_element_by_css_selector(".xblock-v1[data-name='mcq_1_1']")
self.assert_choice_feedback(mcq, choice_index, expected_feedback, correct)
Expand Down