Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SE-3690 Update the Open edX logo urls (backport to opencraft-release/juniper.3) #299

Merged
merged 1 commit into from
Dec 19, 2020
Merged

SE-3690 Update the Open edX logo urls (backport to opencraft-release/juniper.3) #299

merged 1 commit into from
Dec 19, 2020

Conversation

samuelallan72
Copy link

@samuelallan72 samuelallan72 commented Dec 17, 2020 •
edited
Loading

Cherry picked from https://github.com/edx/edx-platform/pull/25898

Test instructions:

  • verify that this cleanly backports the referenced pull request
  • check an instance or your devstack with this branch, and verify that the new logos are displayed

Author notes:

  • This also updates the http open.edx.org links to https, matching upstream. Did this because there was a merge conflict on those lines, and updating to https made sense.

Reviewers:

@nedbat
Update the Open edX logo urls (openedx#25898)
a94e819 
The old URLs now serve the new logo, but at the old pixel size.  These
URLs serve the new logo at a natural pixel size.

(cherry picked from commit 3abd0e8)
@samuelallan72 samuelallan72 self-assigned this Dec 17, 2020
mavidser
mavidser approved these changes Dec 19, 2020
View reviewed changes
Copy link

@mavidser mavidser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @swalladge - Good to merge 👍

  • I tested this: Checked that the logos are updated
  • I read through the code

@samuelallan72 samuelallan72 merged commit 370ffc4 into opencraft-release/juniper.3 Dec 19, 2020
@samuelallan72 samuelallan72 deleted the samuel/new-openedx-logo-urls branch December 19, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavidser mavidser mavidser approved these changes

@pomegranited pomegranited Awaiting requested review from pomegranited

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelallan72 @mavidser @nedbat