Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some mypy errors #219

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Fix some mypy errors #219

merged 2 commits into from
Nov 28, 2023

Conversation

jpmckinney
Copy link
Member

@jpmckinney jpmckinney commented Nov 28, 2023

Part of #217

  • chore(typing): Use cast() between compatible models for type checker
  • chore(typing): Re-order get_new_contracts for clarity (and avoid changing types in reassignments)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7020947513

  • 2 of 7 (28.57%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 86.319%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/sources/colombia.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
app/sources/colombia.py 1 72.62%
app/commands.py 3 96.49%
Totals Coverage Status
Change from base Build 7020146929: 0.1%
Covered Lines: 2000
Relevant Lines: 2317

💛 - Coveralls

@yolile yolile merged commit d057cb8 into main Nov 28, 2023
5 checks passed
@yolile yolile deleted the chore-typing branch November 28, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants