feat: add pnpm setup step for GitHub Actions workflows #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements automatic pnpm support for GithubCDKPipeline: - Created PnpmSetupStep class that uses pnpm/action-setup@v4 GitHub Action - Modified provideInstallStep() to automatically inject pnpm setup when: - Package manager is set to pnpm - Pipeline engine is GitHub - Updated renderInstallPackageCommands() to support pnpm package installation - Automatically uses pnpmVersion from project configuration if available The pnpm setup step is now automatically added to all workflow jobs: - synth jobs - assetUpload jobs - deploy-* jobs This fixes the "npx: command not found: pnpm" error when projects use pnpm as their package manager. Fixes #161
hoegertn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for automatically setting up pnpm in GitHub Actions workflows when a project uses pnpm as its package manager.
Changes
PnpmSetupStepclass: A pipeline step that uses thepnpm/action-setupGitHub Action to install and configure pnpm before running install commandsPnpmSetupStepOptionsinterface: Configuration options for the pnpm setup step, including an optional version parameter (defaults to '9')PnpmSetupStepis automatically injected into the install step sequence when:pnpm addcommand in the CDK pipeline base classImplementation Details
CDKPipeline.provideInstallStep()PnpmSetupStepOptions, with a sensible default of version '9'to*()methodsTesting
The changes ensure that pnpm projects will have pnpm properly installed and available in their GitHub Actions workflows before any package installation commands are executed.