feat: Allow separate asset upload jobs per environment #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security, we require a Github Environment to be specified on a job before allowing it to assume an AWS Role. For example, only a job with
environment: qacan assume a role in our QA AWS account.This requirement prevents the AssetUpload Job from running since there is no "environment" specified. If we use the
assetPublishingPerStageproperty, it tries to change to the appropriate role for each stage (qa, uat, etc...), but, even if we add anenvironmentit will not work since a job can only have one environment.This PR proposes a
useGithubEnvironmentsForAssetUploadboolean property that will allow creation of a separate Job for each stage that can run in parallel and assigns anenvironmentfor each job.