feat: Replace versioning with cdk-devops library #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the local versioning implementation and re-export from cdk-devops instead. Changes: - Update versioning/index.ts to re-export from cdk-devops - Keep VersioningSetup locally (projen-specific task creation) - Remove local versioning source files (types, config, strategy, etc.) - Remove versioning unit tests - Add cdk-devops as peer dependency - Update setup.ts to import from and require cdk-devops BREAKING CHANGE: Versioning API now comes from cdk-devops. Some factory methods like VersioningOutputs.standard() may have different signatures or may need to be added to cdk-devops.
- Update exports to include all cdk-devops types and aliases - Add VersioningOutputsFactory and alias as VersioningOutputs for backward compatibility - Export computeVersion function - Simplify setup.ts to use static computeVersion instead of inline script This significantly reduces code duplication by using the version computation logic from cdk-devops directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #