Skip to content

chore(docs): Some (small) improvements to the Makefile - #909

Merged
8R0WNI3 merged 1 commit into
open-component-model:masterfrom
8R0WNI3:makefile
Aug 10, 2026
Merged

chore(docs): Some (small) improvements to the Makefile#909
8R0WNI3 merged 1 commit into
open-component-model:masterfrom
8R0WNI3:makefile

Conversation

@8R0WNI3

@8R0WNI3 8R0WNI3 commented Aug 10, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

  • Use docker-buildx for image build
  • Use a multi-platform build by default (match GitHub-Actions settings)
  • Properly cleanup all build artifacts

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


- Use `docker-buildx` for image build
- Use a multi-platform build by default (match GitHub-Actions settings)
- Properly cleanup all build artifacts

Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
@8R0WNI3 8R0WNI3 self-assigned this Aug 10, 2026
@8R0WNI3
8R0WNI3 requested a review from a team as a code owner August 10, 2026 06:03
@8R0WNI3 8R0WNI3 added the kind/chore chore, maintenance, etc. label Aug 10, 2026
@8R0WNI3 8R0WNI3 added the area/quality Output qualification (tests, checks, scans, automation in general, etc.) related label Aug 10, 2026
@github-project-automation github-project-automation Bot moved this to 🔦 Needs Triage in Open Delivery Gear Aug 10, 2026
@8R0WNI3 8R0WNI3 moved this from 🔦 Needs Triage to 🔍 Review in Open Delivery Gear Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Makefile now builds Docker images for Linux amd64 and arm64 with Buildx. The clean target now removes src/*.egg-info artifacts.

Changes

Build maintenance

Layer / File(s) Summary
Makefile target updates
Makefile
The Docker build target uses docker-buildx build for linux/amd64 and linux/arm64. The clean target removes src/*.egg-info files.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: a-thaler

Poem

A rabbit checks the build with care,
Two sturdy platforms fill the air.
Old egg-info hops away,
Clean paths greet the working day.
Buildx leads the way!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the Makefile improvements and matches the pull request changes, although the docs scope is slightly imprecise.
Description check ✅ Passed The description covers the buildx, multi-platform build, cleanup, and release note changes; the issue and reviewer notes sections are empty.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Makefile`:
- Line 106: Update the build command invoking Buildx to use the Docker CLI form,
`docker buildx build`, instead of the standalone `docker-buildx build`
executable.
- Around line 106-109: Update the docker-buildx build invocation to use a
compatible multi-platform output: add --push when producing a registry manifest,
or use --load only if this target is intended to create a local single-platform
image. Ensure the selected output matches the target’s expected image
consumption.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ce7bdfc5-9fe6-4833-9185-eaa82eaf53c8

📥 Commits

Reviewing files that changed from the base of the PR and between 525910b and 624c04d.

📒 Files selected for processing (1)
  • Makefile

Comment thread Makefile
Comment thread Makefile

@ChrisSchneider ChrisSchneider left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@8R0WNI3
8R0WNI3 merged commit 61ccc64 into open-component-model:master Aug 10, 2026
19 checks passed
@8R0WNI3
8R0WNI3 deleted the makefile branch August 10, 2026 06:49
@github-project-automation github-project-automation Bot moved this from 🔍 Review to 🍺 Done in Open Delivery Gear Aug 10, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Aug 18, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/chore chore, maintenance, etc.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants