chore(docs): Some (small) improvements to the Makefile - #909
Merged
Conversation
- Use `docker-buildx` for image build - Use a multi-platform build by default (match GitHub-Actions settings) - Properly cleanup all build artifacts Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
Contributor
📝 WalkthroughWalkthroughThe Makefile now builds Docker images for Linux amd64 and arm64 with Buildx. The clean target now removes ChangesBuild maintenance
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Line 106: Update the build command invoking Buildx to use the Docker CLI form,
`docker buildx build`, instead of the standalone `docker-buildx build`
executable.
- Around line 106-109: Update the docker-buildx build invocation to use a
compatible multi-platform output: add --push when producing a registry manifest,
or use --load only if this target is intended to create a local single-platform
image. Ensure the selected output matches the target’s expected image
consumption.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
docker-buildxfor image buildWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: