[fix] output sequence under the multiple samples #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuauty
force-pushed
the
sequence_under_multiple_samples
branch
from
50c9666 to
44ee117
Compare
MaiziXiao
reviewed
Nov 21, 2024
opencompass/models/bailing_api_oc.py
Outdated
| for future in concurrent.futures.as_completed(future_to_m): | ||
| m = future_to_m[future] # noqa F841 | ||
| resp = future.result() | ||
| if resp and resp.status_code == 200: | ||
| try: | ||
| result = resp.json() | ||
| except Exception as e: # noqa F841 | ||
| results.append('') | ||
| pass |
There was a problem hiding this comment.
pass 的话 results数量会和问题数量不一致
There was a problem hiding this comment.
这个修改使用的in-place方式，预先用空值把results和输入的数量对齐了。这个地方改为记录日志供分析使用。
cuauty
force-pushed
the
sequence_under_multiple_samples
branch
from
6083545 to
8543be3
Compare
cuauty
force-pushed
the
sequence_under_multiple_samples
branch
from
8543be3 to
7c3e2de
Compare
cuauty
force-pushed
the
sequence_under_multiple_samples
branch
from
0488462 to
ef5c0e7
Compare
cuauty
force-pushed
the
sequence_under_multiple_samples
branch
from
ef5c0e7 to
4894346
Compare
cuauty
force-pushed
the
sequence_under_multiple_samples
branch
from
4894346 to
6b726ef
Compare
cuauty
force-pushed
the
sequence_under_multiple_samples
branch
from
b7606c9 to
0030bde
Compare
cuauty
force-pushed
the
sequence_under_multiple_samples
branch
from
0030bde to
e4f2313
Compare
cuauty
force-pushed
the
sequence_under_multiple_samples
branch
from
92cd23f to
ac61557
Compare
cuauty
force-pushed
the
sequence_under_multiple_samples
branch
from
7ebc8d1 to
ee20130
Compare
cuauty
force-pushed
the
sequence_under_multiple_samples
branch
from
ee20130 to
a54a21f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
This PR makes the same sequence with input sample under the multiple samples.
Modification
Please briefly describe what modification is made in this PR.
construct the result list in advance then set the result of each sample in-place.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: