Transformer mode #77
Draft
Transformer mode #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JustinKuli
force-pushed
the
transformer-mode
branch
from
9b8c2ef
to
85667ec
Compare
Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
This will help enable usage of this plugin as a transformer. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
transformer-mode
branch
from
85667ec
to
b0dbfaf
Compare
Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
transformer-mode
branch
from
b0dbfaf
to
3a75e9f
Compare
When run as a container by kustomize (by setting an annotation in the generator yaml), kustomize will send the configuration and other inputs to the process via stdin. New code converts that input into the format that the generator currently expects. The examples here should make it more clear. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
|
SonarCloud Quality Gate failed. |
|
@JustinKuli: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first few commits refactor how manifests are read in, especially the new-ish kustomization.yaml handling logic. I think the result is a little more readable, but obviously that's just an opinion, and I could back out those changes. I would squash those changes before merging here - they're individual steps to try and make the changes more clear during review.