Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable caching secret, SA and configmap when the placementrule contr… #414

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

xiangjingli
Copy link
Collaborator

…oller is started

  • I have taken backward compatibility into consideration.

https://issues.redhat.com/browse/ACM-14957

The fix has two parts

  • improve the placementrule controller reconciliation performance. The hot fix has been verified on scale test env and the customer site.
  • enlarge the memory limit of the application-manager addon pod to 4G by default.

…oller is started

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (dfcbf0c) to head (a20bcf7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   56.66%   56.72%   +0.06%     
==========================================
  Files          68       68              
  Lines       15248    15236      -12     
==========================================
+ Hits         8640     8643       +3     
+ Misses       5746     5730      -16     
- Partials      862      863       +1     
Flag Coverage Δ
unit 56.72% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikeshng,xiangjingli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants