requeue spoke token controller until the application-manager SA secre… #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t token is ready Signed-off-by: Xiangjing Li <xiangli@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 56.28% 56.43% +0.15%
==========================================
Files 68 68
Lines 15243 15248 +5
==========================================
+ Hits 8579 8605 +26
+ Misses 5805 5788 -17
+ Partials 859 855 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t token is ready
https://issues.redhat.com/browse/ACM-13250
The fix is to address the issue found in AKS cluster
When the SA token secret
open-cluster-management-agent-addon/application-managerwas created, AKS didn't generate the token right away. So the spoken token controller regards it as an invalid token secret, and the secret was deleted and regenerated.We observed the token secret was in create-delete-recreate-delete loop for over 1 hour. Once AKS cluster performance is back, the SA token secret was created with the token as expected. Consequently the AKS cluster secret was generated in the ArgoCD NS