Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App lifecyle CRD api description updates #403

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

xiangjingli
Copy link
Collaborator

@xiangjingli xiangjingli commented Jun 17, 2024

  • I have taken backward compatibility into consideration.

https://issues.redhat.com/browse/ACM-8973

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiangjingli xiangjingli requested review from jc-berger and removed request for lennysgarage and philipwu08 June 17, 2024 23:52
@xiangjingli
Copy link
Collaborator Author

@jc-berger You may just review the following two types.go. The other CRDs are generated files based on the types.go

  • pkg/apis/apps/v1/subscription_types.go
  • pkg/apis/apps/placementrule/v1/placementrule_types.go

@xiangjingli
Copy link
Collaborator Author

/test test

Copy link
Contributor

openshift-ci bot commented Jun 18, 2024

@xiangjingli: No presubmit jobs available for open-cluster-management-io/multicloud-operators-subscription@main

In response to this:

/test test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.62%. Comparing base (1ce18af) to head (ae1d18b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   56.65%   56.62%   -0.03%     
==========================================
  Files          68       68              
  Lines       15207    15207              
==========================================
- Hits         8615     8611       -4     
- Misses       5729     5736       +7     
+ Partials      863      860       -3     
Flag Coverage Δ
unit 56.62% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants