-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App lifecyle CRD api description updates #403
Conversation
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jc-berger You may just review the following two types.go. The other CRDs are generated files based on the types.go
|
/test test |
@xiangjingli: No presubmit jobs available for open-cluster-management-io/multicloud-operators-subscription@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 56.65% 56.62% -0.03%
==========================================
Files 68 68
Lines 15207 15207
==========================================
- Hits 8615 8611 -4
- Misses 5729 5736 +7
+ Partials 863 860 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
https://issues.redhat.com/browse/ACM-8973