Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more comments and descriptions for HelmRelease CR fields #402

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

mikeshng
Copy link
Member

  • I have taken backward compatibility into consideration.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.80%. Comparing base (211bdbc) to head (0a1a2c3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   56.76%   56.80%   +0.03%     
==========================================
  Files          68       68              
  Lines       15207    15207              
==========================================
+ Hits         8632     8638       +6     
+ Misses       5713     5707       -6     
  Partials      862      862              
Flag Coverage Δ
unit 56.80% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjingli
Copy link
Collaborator

@mikeshng FYI The e2e test test/e2e/cases/01-placement/ failed. It seems the helm chart was not deployed for some reason. Not sure if it is related to the helmrelease CRD update.

Copy link
Collaborator

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-berger, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants