Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spoke token controller unit test fix along with app addon ns customiz… #398

Merged
merged 1 commit into from
May 10, 2024

Conversation

xiangjingli
Copy link
Collaborator

@xiangjingli xiangjingli commented May 10, 2024

…ation

  • I have taken backward compatibility into consideration.

The spoke token controller unit test is fixed due to the unit test failure observed in the midstream repo, where the unit test is executed inside of a k8s pod in Prow CI/CD env. Its pod namespace is shared with the unit test job. So the SA in the unit test is actually created in the unit test k8s pod NS.

Though the unit test failure doesn't happen in upstream repo as upstream CI/CD is github workflow rather than the k8s Prow, It is better to merge it back to upstream to keep the code consistency.

…ation

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
@openshift-ci openshift-ci bot requested review from jnpacker and mikeshng May 10, 2024 16:56
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.52%. Comparing base (f9dc1e6) to head (085d055).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   56.21%   56.52%   +0.30%     
==========================================
  Files          68       68              
  Lines       15191    15191              
==========================================
+ Hits         8539     8586      +47     
+ Misses       5795     5754      -41     
+ Partials      857      851       -6     
Flag Coverage Δ
unit 56.52% <ø> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant