Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch application-manager SA secrets in the customized app addon NS #397

Merged
merged 1 commit into from
May 10, 2024

Conversation

xiangjingli
Copy link
Collaborator

  • I have taken backward compatibility into consideration.

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
@openshift-ci openshift-ci bot requested review from jnpacker and philipwu08 May 9, 2024 23:09
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.80%. Comparing base (25d7b3d) to head (1e48d2b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   56.17%   55.80%   -0.38%     
==========================================
  Files          68       68              
  Lines       15174    15191      +17     
==========================================
- Hits         8524     8477      -47     
- Misses       5797     5865      +68     
+ Partials      853      849       -4     
Flag Coverage Δ
unit 55.80% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant