Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Helm for the policy generator #387

Conversation

dhaiducek
Copy link
Member

ref: https://issues.redhat.com/browse/ACM-9060

  • I have taken backward compatibility into consideration.

/cc @mprahl

ref: https://issues.redhat.com/browse/ACM-9060
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
@openshift-ci openshift-ci bot requested a review from mprahl February 5, 2024 21:31
@mikeshng
Copy link
Member

mikeshng commented Feb 5, 2024

/approve

please feel free to l g t m whenever

@openshift-ci openshift-ci bot added the approved label Feb 5, 2024
@dhaiducek
Copy link
Member Author

Thanks @mikeshng! Would you re-run the Go / test workflow? I'm not sure why that one would have failed with this change.

@mikeshng
Copy link
Member

mikeshng commented Feb 6, 2024

Test seems to ran fine the last time but the report coverage server had issue. Retrying again.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cfc950) 55.21% compared to head (1f9061b) 55.48%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   55.21%   55.48%   +0.27%     
==========================================
  Files          71       71              
  Lines       15317    15317              
==========================================
+ Hits         8457     8499      +42     
+ Misses       6011     5962      -49     
- Partials      849      856       +7     
Flag Coverage Δ
unit 55.48% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhaiducek
Copy link
Member Author

Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, gparvin, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 766d357 into open-cluster-management-io:main Feb 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants