Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade addon-framework version #385

Conversation

haoqing0110
Copy link
Member

@haoqing0110 haoqing0110 commented Feb 5, 2024

@haoqing0110
Copy link
Member Author

/assign @mikeshng @xiangjingli

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b397c5) 55.66% compared to head (f7fa32f) 54.98%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   55.66%   54.98%   -0.68%     
==========================================
  Files          71       71              
  Lines       15315    15317       +2     
==========================================
- Hits         8525     8422     -103     
- Misses       5937     6056     +119     
+ Partials      853      839      -14     
Flag Coverage Δ
unit 54.98% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: haoqing0110 <qhao@redhat.com>
@xiangjingli
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 5, 2024
@xiangjingli
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6cfc950 into open-cluster-management-io:main Feb 5, 2024
9 checks passed
@haoqing0110 haoqing0110 deleted the br_update-framework branch February 5, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants