Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable readOnlyRootFilesystem on subscription addon pod #384

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

xiangjingli
Copy link
Collaborator

  • I have taken backward compatibility into consideration.

https://issues.redhat.com/browse/ACM-8463

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikeshng,xiangjingli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b397c5) 55.66% compared to head (c1244b5) 55.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   55.66%   55.26%   -0.40%     
==========================================
  Files          71       71              
  Lines       15315    15317       +2     
==========================================
- Hits         8525     8465      -60     
- Misses       5937     6003      +66     
+ Partials      853      849       -4     
Flag Coverage Δ
unit 55.26% <ø> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants