Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return true if both allowed is false and denied is false in SubjectAc… #132

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

xiangjingli
Copy link
Collaborator

…cessReviewSpec result

Signed-off-by: Xiangjing Li xiangli@redhat.com

https://github.com/stolostron/backlog/issues/20916

…cessReviewSpec result

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
@xiangjingli xiangjingli requested review from philipwu08 and rokej and removed request for jnpacker March 21, 2022 17:03
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
@mikeshng
Copy link
Member

/approve

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikeshng,xiangjingli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e528cdd into main Mar 21, 2022
@xiangjingli xiangjingli deleted the denyFalse branch March 21, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants