Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ansible posthook not creating AnsibleJob CR #114

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fix Ansible posthook not creating AnsibleJob CR #114

merged 1 commit into from
Mar 11, 2022

Conversation

mikeshng
Copy link
Member

Signed-off-by: Mike Ng ming@redhat.com

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikeshng
Copy link
Member Author

/hold

Expecting the added e2e to fail. When the actual fix is included in the PR, the e2e will then pass.

@mikeshng mikeshng changed the title [WIP] Fix Ansible posthook not creating AnsibleJob CR Fix Ansible posthook not creating AnsibleJob CR Mar 11, 2022
@mikeshng
Copy link
Member Author

/unhold

Signed-off-by: Mike Ng <ming@redhat.com>
@xiangjingli
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit ba2c012 into open-cluster-management-io:main Mar 11, 2022
@mikeshng mikeshng deleted the fix-ansible-post branch March 11, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants