Skip to content

Commit

Permalink
avoid error status accumulation when failing to fetch hub channel (#408)
Browse files Browse the repository at this point in the history
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
  • Loading branch information
xiangjingli authored Jul 29, 2024
1 parent 7ecb081 commit 90b7a75
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/controller/subscription/subscription_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ func (r *ReconcileSubscription) doReconcile(instance *appv1.Subscription) error

err = r.hubclient.Get(context.TODO(), chnkey, subitem.Channel)
if err != nil {
return gerr.Wrapf(err, "failed to get channel of subscription %v", instance)
return gerr.Wrap(err, "failed to get channel")
}
}

Expand All @@ -351,7 +351,7 @@ func (r *ReconcileSubscription) doReconcile(instance *appv1.Subscription) error

err = r.hubclient.Get(context.TODO(), scndChnkey, subitem.SecondaryChannel)
if err != nil {
return gerr.Wrapf(err, "failed to get the secondary channel of subscription %v", instance)
return gerr.Wrap(err, "failed to get the secondary channel")
}
}
}
Expand Down

0 comments on commit 90b7a75

Please sign in to comment.