Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove static from build #79

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Remove static from build #79

merged 1 commit into from
Jul 6, 2023

Conversation

lennysgarage
Copy link
Member

  • I have taken backward compatibility into consideration.

Remove static flag from build arguments.

Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>
@openshift-ci openshift-ci bot requested review from chenz4027 and rokej July 6, 2023 17:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lennysgarage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 6, 2023
@lennysgarage
Copy link
Member Author

Will merge changes to release-2.8, 2.7, and 2.6.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5e3e2cb) 72.72% compared to head (56d7399) 72.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files          13       13           
  Lines        1635     1635           
=======================================
  Hits         1189     1189           
  Misses        352      352           
  Partials       94       94           
Flag Coverage Δ
unit 72.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lennysgarage lennysgarage requested review from xiangjingli and removed request for chenz4027 and rokej July 6, 2023 17:19
@xiangjingli
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants