This repository was archived by the owner on Jun 2, 2025. It is now read-only.
Allow the channel controller to be able to run outside of cluster #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
xiangjingli
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiangjing Li xiangli@redhat.com
The channel controller is supported to specify an external kubeconfig argument, so that the channel controller running on a management cluster can reconcile resources deployed on the hosted clusters.
Two clients (inCluster Client and outCluster Client) are maintained, so that the channel controller is able to update the webhook configuration service in the hosted cluster by outClient client and update the webhook server service in the management cluster by inCluster client
If the kubeconfig argument is not specified, the channel controller is to use inCluster client by default. This is to align with the current ACM installation.