Skip to content

chore: update liveness and readiness probes to improve startup times #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jul 28, 2025
Merged

chore: update liveness and readiness probes to improve startup times #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 5 additions & 21 deletions fleetconfig-controller/charts/fleetconfig-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,35 +46,19 @@ spec:
imagePullPolicy: {{ quote .Values.image.pullPolicy }}
name: manager
resources:
{{- toYaml .Values.resources | nindent 12 }}
{{- toYaml .Values.resources | nindent 10 }}
securityContext:
{{- toYaml .Values.containerSecurityContext | nindent 12 }}
{{ if .Values.admissionWebhooks.enabled }}
{{- toYaml .Values.containerSecurityContext | nindent 10 }}
{{- if .Values.admissionWebhooks.enabled }}
ports:
- containerPort: {{ .Values.webhookService.port }}
name: webhook-server
protocol: TCP
- containerPort: {{ .Values.healthCheck.port }}
name: healthz
protocol: TCP
livenessProbe:
httpGet:
path: /healthz
port: healthz
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.livenessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.livenessProbe.failureThreshold }}
successThreshold: {{ .Values.livenessProbe.successThreshold }}
readinessProbe:
httpGet:
path: /readyz
port: healthz
initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.readinessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.readinessProbe.failureThreshold }}
successThreshold: {{ .Values.readinessProbe.successThreshold }}
livenessProbe: {{- toYaml .Values.livenessProbe | nindent 10 }}
readinessProbe: {{- toYaml .Values.readinessProbe | nindent 10 }}
volumeMounts:
- mountPath: {{ .Values.admissionWebhooks.certificate.mountPath }}
name: tls-cert-vol
Expand Down
12 changes: 9 additions & 3 deletions fleetconfig-controller/charts/fleetconfig-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,17 +321,23 @@ healthCheck:

## @skip readinessProbe
readinessProbe:
httpGet:
path: /readyz
port: healthz
failureThreshold: 3
initialDelaySeconds: 30
initialDelaySeconds: 3
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1

## @skip livenessProbe
livenessProbe:
httpGet:
path: /healthz
port: healthz
failureThreshold: 3
initialDelaySeconds: 90
periodSeconds: 5
initialDelaySeconds: 15
periodSeconds: 20
successThreshold: 1
timeoutSeconds: 1

Expand Down
Loading