Move the disabled events recording outside of spec-sync #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
added a commit
to mprahl/governance-policy-propagator-1
that referenced
this pull request
Apr 15, 2024
This is now handled in the governance-policy-framework-addon: open-cluster-management-io/governance-policy-framework-addon#132 Relates: https://issues.redhat.com/browse/ACM-10418 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
force-pushed
the
fix-flaky-disable
branch
from
5dffd33
to
e380d50
Compare
mprahl
added a commit
to mprahl/governance-policy-propagator-1
that referenced
this pull request
Apr 15, 2024
This is now handled in the governance-policy-framework-addon: open-cluster-management-io/governance-policy-framework-addon#132 Relates: https://issues.redhat.com/browse/ACM-10418 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
dhaiducek
previously approved these changes
Apr 15, 2024
|
@dhaiducek thanks for the review Dale! After thinking about this, I think I need to guarantee the watch starts from a point before the spec-sync starts in order to not miss and delete policy events. I'll address that in a bit. /hold |
There were issues with duplicated compliance events and having a different code path in the governance-policy-propagator for a self-managed hub. This will unifies the approaches. It takes the approach of using a retry watcher and just generating the disabled event when the policy is deleted. The controller-runtime library cannot be used because when there is a reconcile event for a deleted object, you don't have access to the object as it was right before deletion. Relates: https://issues.redhat.com/browse/ACM-10418 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
force-pushed
the
fix-flaky-disable
branch
from
e380d50
to
7dace50
Compare
|
/unhold |
JustinKuli
approved these changes
Apr 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5dd1a53
into
open-cluster-management-io:main
9 checks passed
mprahl
added a commit
to open-cluster-management-io/governance-policy-propagator
that referenced
this pull request
Apr 18, 2024
This is now handled in the governance-policy-framework-addon: open-cluster-management-io/governance-policy-framework-addon#132 Relates: https://issues.redhat.com/browse/ACM-10418 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
magic-mirror-bot bot
pushed a commit
to stolostron/governance-policy-propagator
that referenced
this pull request
Apr 18, 2024
This is now handled in the governance-policy-framework-addon: open-cluster-management-io/governance-policy-framework-addon#132 Relates: https://issues.redhat.com/browse/ACM-10418 Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 0a78fa3)
magic-mirror-bot bot
pushed a commit
to stolostron/governance-policy-propagator
that referenced
this pull request
Apr 18, 2024
This is now handled in the governance-policy-framework-addon: open-cluster-management-io/governance-policy-framework-addon#132 Relates: https://issues.redhat.com/browse/ACM-10418 Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 0a78fa3)
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/governance-policy-propagator
that referenced
this pull request
Apr 18, 2024
This is now handled in the governance-policy-framework-addon: open-cluster-management-io/governance-policy-framework-addon#132 Relates: https://issues.redhat.com/browse/ACM-10418 Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 0a78fa3)
openshift-merge-bot bot
pushed a commit
to stolostron/governance-policy-propagator
that referenced
this pull request
Apr 18, 2024
This is now handled in the governance-policy-framework-addon: open-cluster-management-io/governance-policy-framework-addon#132 Relates: https://issues.redhat.com/browse/ACM-10418 Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 0a78fa3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this is the related PR in the propagator: open-cluster-management-io/governance-policy-propagator#215
There were issues with duplicated compliance events and having a different code path in the governance-policy-propagator for a self-managed hub. This will unifies the approaches.
It takes the approach of using a retry watcher and just generating the disabled event when the policy is deleted. The controller-runtime library cannot be used because when there is a reconcile event for a deleted object, you don't have access to the object as it was right before deletion.
Relates:
https://issues.redhat.com/browse/ACM-10418