Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve package dependencies if the top-level CSV is approved #307

Merged

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented Oct 21, 2024

This handles InstallPlans that have multiple CSVs listed in them due to package dependencies.

Relates:
https://issues.redhat.com/browse/ACM-14540

This handles InstallPlans that have multiple CSVs listed in them due to
package dependencies.

Relates:
https://issues.redhat.com/browse/ACM-14540

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
@mprahl mprahl changed the title WIP: Approve package dependencies if the top-level CSV is approved Approve package dependencies if the top-level CSV is approved Oct 23, 2024
@mprahl mprahl marked this pull request as ready for review October 23, 2024 20:41
Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f053fe8 into open-cluster-management-io:main Oct 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants