🐛 Check if managed cluster is created during join #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiujian16
force-pushed
the
wait-cluster
branch
3 times, most recently
from
2c95421
to
db63d4d
Compare
This is to check if managed cluster is created when using --wait flag with join command, using the bootstrap secret Signed-off-by: Jian Qiu <jqiu@redhat.com>
|
/hold |
|
CC @nirs |
|
/assign @zhujian7 |
zhujian7
reviewed
Apr 9, 2024
| } | ||
|
|
||
| phase := &atomic.Value{} | ||
| phase.Store("") |
There was a problem hiding this comment.
what is the phase.Store("") used for?
we did not print any status
There was a problem hiding this comment.
it could show whether cluster is created
|
/lgtm |
|
/unhold |
openshift-merge-bot
bot
merged commit 8fe6644
into
open-cluster-management-io:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to check if managed cluster is created
when using --wait flag with join command, using
the bootstrap secret
Summary
Related issue(s)
Fixes #410