🐛 Disable the propagator webhook; Add ClusterManagementAddon manifests #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A webhook was added, but it requires cert-manager as a prerequisite. Until we can resolve/update that, leave it disabled by default. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
openshift-ci
bot
requested review from
mikeshng,
mprahl,
qiujian16,
ycyaoxdu,
yiraeChristineKim and
yue9944882
A new check blocked enabling addons if this is missing. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
disable-webhook
branch
from
c1d9500
to
df3c43a
Compare
|
Sorry for blowing up the reviewer list here, but I'm verifying If this all looks good, after it merges I'd appreciate if we could cut a new release on (or before) Monday. (My presentation is at 6 PM UTC on Monday.) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit c43d888
into
open-cluster-management-io:main
9 checks passed
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Nov 11, 2023
Version 0.7.0 was broken so we had to include detailed instructions for installing 0.6.0. The issue was fixed in 0.7.1 by [1]. Update the instructions to require the new version and remove the now unneeded instructions. Tested with ocm.yaml. [1] open-cluster-management-io/clusteradm#388 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
raghavendra-talur
pushed a commit
to RamenDR/ramen
that referenced
this pull request
Dec 8, 2023
Version 0.7.0 was broken so we had to include detailed instructions for installing 0.6.0. The issue was fixed in 0.7.1 by [1]. Update the instructions to require the new version and remove the now unneeded instructions. Tested with ocm.yaml. [1] open-cluster-management-io/clusteradm#388 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
ShyamsundarR
pushed a commit
to red-hat-storage/ramen
that referenced
this pull request
Dec 13, 2023
Version 0.7.0 was broken so we had to include detailed instructions for installing 0.6.0. The issue was fixed in 0.7.1 by [1]. Update the instructions to require the new version and remove the now unneeded instructions. Tested with ocm.yaml. [1] open-cluster-management-io/clusteradm#388 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A GRC webhook was added, but it requires cert-manager as a prerequisite. Until we can resolve/update that, leave it disabled by default.
Also, there was a check added for ClusterManagementAddon, which were not deployed originally, currently causing an error during enabling app and policy addons:
clusteradm/pkg/cmd/addon/enable/exec.go
Lines 110 to 114 in ed10693
/cc @mprahl @yiraeChristineKim @mikeshng @qiujian16 @ycyaoxdu @yue9944882