Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go v1.17 and upgrade packages #168

Merged

Conversation

dhaiducek
Copy link
Member

Seemed like a good thing to do since Go v1.16 is EOL.

This new replace statement is because the gnostic package recently switched paths from googleapis/gnostic to google/gnostic and the latest commit of kube-openapi picked up the change but we can't update to it yet as far as I can tell:

	k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20220310132336-3f90b8c54bbb

@openshift-ci openshift-ci bot requested review from itdove and qiujian16 March 21, 2022 21:57
@dhaiducek dhaiducek force-pushed the upgrade-go branch 2 times, most recently from 80c8cc6 to 8ad9321 Compare March 21, 2022 22:13
Signed-off-by: Dale Haiducek <dhaiduce@redhat.com>
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 10bdc63 into open-cluster-management-io:main Mar 22, 2022
@dhaiducek dhaiducek deleted the upgrade-go branch March 22, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants