Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: clusteradm delete clusterset #154

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Feat: clusteradm delete clusterset #154

merged 2 commits into from
Mar 15, 2022

Conversation

ycyaoxdu
Copy link
Member

Signed-off-by: ycyaoxdu yaoyuchen0626@163.com

1.add command : clusteradm delete clusterset
2.modify some out information

@openshift-ci openshift-ci bot requested review from itdove and qiujian16 March 15, 2022 05:15
@ycyaoxdu
Copy link
Member Author 

╰─$ clusteradm get clustersets                                     
NAME      BOUND NAMESPACES   STATUS
default                      1 ManagedClusters selected
set1      default            No ManagedCluster selected

╭─yuyao@redhats-MacBook-Pro ~/go/src/clusteradm ‹feat/delete-clusterset› 
╰─$ clusteradm delete clusterset set1
Clusterset set1 still bind to a namespace! Please unbind before deleted.

╭─yuyao@redhats-MacBook-Pro ~/go/src/clusteradm ‹feat/delete-clusterset› 
╰─$ clusteradm clusterset unbind set1 --namespace default          
Clusterset default is unbind from Clusterset set1

╭─yuyao@redhats-MacBook-Pro ~/go/src/clusteradm ‹feat/delete-clusterset› 
╰─$ clusteradm delete clusterset set1                      
Clusterset set1 is deleted

╭─yuyao@redhats-MacBook-Pro ~/go/src/clusteradm ‹feat/delete-clusterset› 
╰─$ clusteradm get clustersets       
NAME      BOUND NAMESPACES   STATUS
default                      1 ManagedClusters selected

@ycyaoxdu
fix: modify output information
18b88c7 
Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com>
@ycyaoxdu
feat: add command delete clusterset
f7d6ccc 
Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com>
qiujian16
qiujian16 reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, ycyaoxdu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit feb9f6d into open-cluster-management-io:main Mar 15, 2022
@ycyaoxdu ycyaoxdu deleted the feat/delete-clusterset branch March 15, 2022 08:10
@ycyaoxdu ycyaoxdu mentioned this pull request Mar 16, 2022
Open
22 tasks
@ycyaoxdu
Copy link
Member Author

#133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiujian16 qiujian16 qiujian16 left review comments

@itdove itdove Awaiting requested review from itdove

Assignees

@qiujian16 qiujian16

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycyaoxdu @qiujian16 @openshift-merge-robot