Allow muting of @everyone notifications

[megrogan]

The website must be upgraded with this commit before this PR is merged - then LUIs/groups/communities need to be upgraded before the website is upgraded with the changes in this PR.

[github-actions]

canbench 🏋 (dir: .)

./canbench_results.yml is up to date ✅

---------------------------------------------------

Benchmark: push_simple_text_messages
  total:
    instructions: 205.78 M (-1.19%) (change within noise threshold)
    heap_increase: 13 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: add_reactions
  total:
    instructions: 1.22 B (-1.04%) (change within noise threshold)
    heap_increase: 4 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

[julianjelfs]

There's something a bit unpleasant about the types here isn't there. We are always doing exactly one thing (mute, unmute, mute everyone, unmute everyone) but all of the interfaces imply that we can do 0, 1 or 2 things.

I wonder if we could hide that unpleasantness until we arrive at the bottom layer.

[megrogan]

There's something a bit unpleasant about the types here isn't there. We are always doing exactly one thing (mute, unmute, mute everyone, unmute everyone) but all of the interfaces imply that we can do 0, 1 or 2 things.

I wonder if we could hide that unpleasantness until we arrive at the bottom layer.

I considered that but we also might want to do multiple things with a slightly different UI. Perhaps clicking a single notifications menu item opens a dialog with options that can all be changed in one go. It makes sense to me that the openchat-client supports this.

[julianjelfs]

There's something a bit unpleasant about the types here isn't there. We are always doing exactly one thing (mute, unmute, mute everyone, unmute everyone) but all of the interfaces imply that we can do 0, 1 or 2 things.
I wonder if we could hide that unpleasantness until we arrive at the bottom layer.

I considered that but we also might want to do multiple things with a slightly different UI. Perhaps clicking a single notifications menu item opens a dialog with options that can all be changed in one go. It makes sense to me that the openchat-client supports this.

So what does it mean to set both things to undefined?

[megrogan]

There's something a bit unpleasant about the types here isn't there. We are always doing exactly one thing (mute, unmute, mute everyone, unmute everyone) but all of the interfaces imply that we can do 0, 1 or 2 things.
I wonder if we could hide that unpleasantness until we arrive at the bottom layer.

I considered that but we also might want to do multiple things with a slightly different UI. Perhaps clicking a single notifications menu item opens a dialog with options that can all be changed in one go. It makes sense to me that the openchat-client supports this.

So what does it mean to set both things to undefined?

Acknowledged, but all other combinations make sense and I don't think the alternative will be nicer.