add RH_ice to moist env thermodynamic state

[slayoo]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (824a94d) to head (3326280).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1496   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         376      376           
  Lines        9266     9267    +1     
=======================================
+ Hits         7897     7898    +1     
  Misses       1369     1369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tluettm]

Is there a reason why the unit test checks for subsaturation specifically?

I also added a second test that checks for the reverse: 1 > RHi > RH for T < 273.16K:
See https://github.com/tluettm/PySDM -> test_rhi

I'm not sure if that is really necessary though. I also don't know if there is a better way of linking my change without pushing the commit to your branch.

[slayoo]

Thank you, @tluettm

Is there a reason why the unit test checks for subsaturation specifically?

Good point. Supersaturated cases added in 3326280

I also added a second test that checks for the reverse: 1 > RHi > RH for T < 273.16K: See https://github.com/tluettm/PySDM -> test_rhi

Thank you! Merged in 3326280

I'm not sure if that is really necessary though. I also don't know if there is a better way of linking my change without pushing the commit to your branch.

Commit on a branch is perfect, optionally we could also setup a PR from tluettm:test_rhi to slayoo:RHi. Committing to the PR branch here (slayoo:RHi) is also OK.

[slayoo]

@tluettm, please merge if the code seems OK and helps