Skip to content

Add 'None' courant field for ShallowWaterScenario tests, change plots in README.md to show MPI calculation in ShallowWaterScenario #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 30, 2025

Conversation

Sfonxu
Copy link
Collaborator

@Sfonxu Sfonxu commented Apr 29, 2025

No description provided.

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (839b4dc) to head (6d4c825).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   71.86%   71.86%           
=======================================
  Files           5        5           
  Lines         263      263           
=======================================
  Hits          189      189           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo
Copy link
Member

slayoo commented Apr 29, 2025

thanks @Sfonxu
there doesn't seem to be any change influencing MPI subdomain plotting (despite the PR title)?

@Sfonxu
Copy link
Collaborator Author

Sfonxu commented Apr 29, 2025

The code is already there, I just have to get the animation filenames from CI and change the README file.

@slayoo slayoo added this pull request to the merge queue Apr 30, 2025
Merged via the queue into open-atmos:main with commit ed37248 Apr 30, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants