Skip to content

Update Elixir version test matrix #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zorbash merged 2 commits into from
Mar 15, 2024
Merged

Update Elixir version test matrix #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
928a442
Update Elixir version test matrix
zorbash Mar 14, 2024
5d5562a
Fix map key order dependent test
zorbash Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/elixir.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,20 @@ jobs:
otp: ['22', '23', '24', '25', '26']
elixir: ['1.11', '1.12', '1.13', '1.14', '1.15', '1.16']
exclude:
- {otp: '25', elixir: '1.10'}
- {otp: '22', elixir: '1.14'}
Copy link
Contributor

@thbar thbar Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- {otp: '22', elixir: '1.14'}
- {otp: '22', elixir: '1.14'}

Elixir 1.14 does not officially support OTP 22 https://hexdocs.pm/elixir/1.16.2/compatibility-and-deprecations.html#between-elixir-and-erlang-otp

- {otp: '22', elixir: '1.15'}
- {otp: '22', elixir: '1.16'}
- {otp: '23', elixir: '1.14'}
- {otp: '23', elixir: '1.15'}
- {otp: '23', elixir: '1.16'}
- {otp: '24', elixir: '1.11'}
- {otp: '24', elixir: '1.12'}
- {otp: '24', elixir: '1.13'}
- {otp: '24', elixir: '1.14'}
- {otp: '24', elixir: '1.15'}
- {otp: '25', elixir: '1.11'}
- {otp: '25', elixir: '1.12'}
- {otp: '26', elixir: '1.10'}
- {otp: '25', elixir: '1.14'}
- {otp: '26', elixir: '1.11'}
Copy link
Contributor

@thbar thbar Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.11 is not supported anymore if I read this correctly:

https://hexdocs.pm/elixir/1.16.2/compatibility-and-deprecations.html

Maybe we can remove an extra one?

- {otp: '26', elixir: '1.12'}
- {otp: '26', elixir: '1.13'}
Expand Down
6 changes: 4 additions & 2 deletions test/paths_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@ defmodule OpenApiSpex.PathsTest do
refute Map.has_key?(paths, "/api/noapi")
refute Map.has_key?(paths, "/api/noapi_with_struct")

assert pets_path_item.put.operationId == "OpenApiSpexTest.PetController.update"
assert pets_path_item.patch.operationId == "OpenApiSpexTest.PetController.update (2)"
operation_ids = [pets_path_item.put.operationId, pets_path_item.patch.operationId]

assert "OpenApiSpexTest.PetController.update" in operation_ids
assert "OpenApiSpexTest.PetController.update (2)" in operation_ids
end
end
end